KDE-CVS-Digest for January 10, 2003
Friday, 10 January 2003 | Dkite
The latest KDE-CVS-Digest is now available. This issue features news about Apple using khtml in Safari and the subsequent merging of Apple's contributions, support for RDP in the KDE Remote Desktop Client (krdc) and numerous bug fixes and new features. Enjoy!
Comments:
again - Caleb Tennis - 2003-01-09
the new format looks very nice, Derek. Great job as always.
Re: again - David Nielsen - 2003-01-10
AWESOME job Derek... I can't thank you enough for these summaries.
HTML breakage - AC - 2003-01-10
Whoops... The page doesn't render properly in Moz 1.0. It gets cut off halfway through the Konqueror bug fixes by a (malformed?) HTML comment. Renders fine in Konq tho (of course).
Re: HTML breakage - AC - 2003-01-10
works for me with mozilla 1.2.1
Re: HTML breakage - AC - 2003-01-10
I guess I should upgrade. Still, those HTML comments should be escaped with < and >. They are in one place, but not another: <p class="line">Dirk Mueller committed a change to kdelibs/khtml/html</p> <pre>handle <!--> and <!---> CCMAIL<a href="http://bugs.kde.org/show_bug.cgi?id=34302">34302</a>-done@bugs.kde.org Backported to KDE_3_1_BRANCHhandle <!--> and <!---> (backport) 3.1rc4 Konq cuts the word "and" out in the last line, at least.
Re: HTML breakage - Derek Kite - 2003-01-10
Does it get screwed up after .... Dirk Mueller committed a change to kdelibs/khtml/ecma don't crash Diff Dirk Mueller committed a change to kdelibs/khtml/html then goes wonky? If so, this is what is there... <pre>make <select><option> text</select> work.... This is somewhere in the middle of the konq. bug section. Could be the early mozilla got confused with the escape characters. Derek (I fixed the email address. speaking of escape characters....)
Re: HTML breakage - Derek Kite - 2003-01-10
Found it. Fixed it. I didn't escape the second instance of the comment. Should be ok now. Ack. Another one. <file>. FIxed. Derek
Re: HTML breakage - AC - 2003-01-10
Thanks. I love the CVS digest, BTW. :-)
Coding style question - em - 2003-01-10
Why do they use !(x == y) instead of x != y for example in http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/khtml/rendering/render_style.cpp.diff?r1=1.54&r2=1.55&f=h ? (And why does the dot prevent me from posting html?)
Re: Coding style question - Justin - 2003-01-10
Re html posts, the Dot has had them disabled for a couple years now, after I reported an exploit in their forum software (someone had used the hole to change all links on this site to some place unmentionable). This problem has either never been solved, or the admins don't want to risk it again.
Re: Coding style question - em - 2003-01-10
That is unfortunate, because it leads to posting URLs as text (instead of hyperlinks) which in turn breaks the page layout in a most annoying way.
Re: Coding style question - Navindra Umanee - 2003-01-10
I don't have any faith in any the HTML parsing code I've seen. It would definitely be nice though, so I'll probably give it a try (this weekend...).
Re: Coding style question - Roberto Alsina - 2003-01-11
In konqueror, everything is an hyperlink! Select the URL, then middle-click, IIRC. That should open the URL.
Re: Coding style question - me - 2003-01-10
Probably to stress that a specific operator (==) is to be used. You can define your own == and != operators for objects, although != will be implicitly mapped to !(==) if it has not been defined. If you have large hierarchies of classes, you tend to lose track of which operator was defined in what class...
Re: Coding style question - David Faure - 2003-01-10
In my experience != is NOT implicitly mapped to !(operator==). So for your own classes, you need to define both ... or to use !(a==b), which is probably why khtml does the latter.
Re: Coding style question - L.Lunak - 2003-01-10
Actually IIRC the reason for using !(a==b) is that libstdc++v2 (shipped with gcc-2.95) wasn't namespace clean and defined a public template operator!=, which took its arguments using references. And since some data members in KHTML classes are bitfields, and one cannot take pointers(i.e. also references) to bitfields, this caused compile errors(the libstdc++ operator was used instead of compiled generating a "normal" one).
Safari changes - Michael - 2003-01-10
The KDE-VCS-digest mentions that some of the Safari changes are incorporated into Konqueror from KDE_3_1_BRANCH. It is planned to incorporate all the Safari changes to Konqueror before releasing KDE3.1. Would be a good idea, I think, even though this may postpone KDE3.1 a little further.
Re: Safari changes - Debian User - 2003-01-10
Each changeset will be judged independantly. Some are trivial to oversee and yet have an impact on the performance, those are likely just commited. Everything that is a harder to oversee change, but makes sense will be commited to HEAD only, probably backported later, when it proved working good enough, for a 3.1.1. And everything else, that is architectural, will see only HEAD and 3.2 That's the natural way to do it and I guess, the KDE people will only do it better. Regards, Kay
Re: Safari changes - Derek Kite - 2003-01-10
>incorporate all the Safari changes to Konqueror before releasing KDE3.1 Some are going in. The easy ones. And the crash fixes. The developers are impressed with the work and using as much as possible as quickly as possible. Someone even told Dirk to go to bed :-) IIRC the Apple people were working from a 3.04 base. So there is a divergence in the two trees which will take a while to sort out. I doubt if 3.1 will be delayed any further. Derek (IMHO)
Apple changes.. - anon - 2003-01-10
Is there anyone working on intergrating the Apple changes to khtml? I assume Apple won't do it,why should they ;)
Re: Apple changes.. - AC - 2003-01-10
Have you read the other comments? :) (yes)
Re: Apple changes.. - Debian User - 2003-01-10
To me it came as a surprise to learn that Apple would not only provide it, but also help merge it. After all, the name is Apple. But if you think of it. While keeping it of course secret to gain an edge over others (who? would Sun even try to learn from them?!), after it was reveiled, it all comes down to cost. And maintaining a branch costs more than incorporating the tested KDE releases with all merges. So they can focus on the UI. And that's what Apple believes they can do best. Seems Ok to me, Kay
Hi mommy! ;-) - Andy Goossens - 2003-01-10
Heh, it's nice to see your own commit showing up in KDE CVS digest. One small remark though: my commit originally contained the text "<quote>Vladimir is really fast in finding and fixing reported bugs</quote>". It looks like those pseudo-tags were lost. Oh, and linebreaks made my commit more understandable :-) You know, last week I was thinking it would have been great if one of my commits did ever show up in the CVS digest. If only all my dreams could become reality... ;-)
Re: Hi mommy! ;-) - Derek Kite - 2003-01-10
> originally contained the text "<quote>Vladimir... I guess I took them out too quickly. I'll put them back. Funny I've never run into this until now. Maybe a plot to keep me on my toes. Derek
Very useful - Dan K. - 2003-01-11
Derek: there's so few comments here, I just want to make sure you know that's because it's so comprehensive and so useful. Wonderful job!
Great job...Again! - beergeek - 2003-01-13
Hey Derek, just another post of praise here. Thanks so much for the hard work. I really enjoy the weekly updates!